Fix MessageDigest parameter validation, add tests#149
Merged
rlm2002 merged 1 commit intowolfSSL:masterfrom Aug 29, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes parameter validation in the MessageDigest.update() method to properly throw exceptions for invalid offset/length parameters instead of silently returning, ensuring compliance with OpenJDK SunJCE behavior.
- Replaces silent return with
RuntimeExceptionfor invalid parameters inMessageDigest.update() - Adds comprehensive JUnit tests for various invalid parameter scenarios
- Updates method documentation to reflect the new exception behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/com/wolfssl/wolfcrypt/MessageDigest.java | Updates parameter validation to throw RuntimeException instead of silently returning |
| src/test/java/com/wolfssl/wolfcrypt/test/Sha256Test.java | Adds test cases for invalid offset/length parameter validation |
| src/test/java/com/wolfssl/provider/jce/test/WolfCryptMessageDigestSha256Test.java | Adds JCE provider test cases for invalid offset/length parameter validation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rlm2002
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
MessageDigest.update()to throw aRuntimeExceptionfor invalid offset/length parameters instead of silently returning.This includes JUnit tests to protect against regressions.
This fixes OpenJDK SunJCE
MessageDigesttests.